Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mitsuhiko/babel#133. #134

Closed
wants to merge 1 commit into from

Conversation

benselme
Copy link
Member

@benselme benselme commented Jan 8, 2015

Fixes the tests that failed with the newer versions of pytz. Fixes #133

This was referenced Jan 8, 2015
st4lk added a commit to st4lk/babel that referenced this pull request Jan 26, 2015
@jrfern
Copy link

jrfern commented Mar 28, 2015

No news is bad news, and this bug prevents the fix for many other bugs. What can be done, @benselme?

@sils
Copy link
Member

sils commented Aug 3, 2015

@jrfern I don't understand your comment fully.
@benselme can you rebase the PR onto current master, correct the reference to point to bug #106 (as it was a duplicate, please use full URL, avoid relying on users viewing the commit message via GitHub), add an explanation so the commit message is valid on its own (it should be, the issue link should provide more information about the issue while the commit message itself should provide enough information to explain the change (not the fix) to the code and justify it.) Take a look at http://coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits/ for a summary of common commit message guidelines.

@sils
Copy link
Member

sils commented Sep 10, 2015

@benselme still around? I can understand frustration of your PR being ignored for such a long time. We took over maintenance shortly ago because the old maintainer (obviously) didn't have enough time to maintain this repo properly. I can assure you, that we will work together with you to get this merged.

@jrfern you seem to be interested in this issue, if @benselme is not around anymore, would you like to ramp this one up to our current standards and submit a replacement PR? We currently don't have the manpower to do more than triaging issues and reviewing and merging PRs because they stacked up pretty high.

@benselme
Copy link
Member Author

I just came back from a long trip. I'll try to fix that PR this week.

@sils
Copy link
Member

sils commented Sep 15, 2015

@benselme cool, many thanks!

@benselme
Copy link
Member Author

Hasn't this been fixed in 9f099d3 already ?

@etanol
Copy link
Contributor

etanol commented Sep 26, 2015

@benselme fixed indeed. Closing.

@etanol etanol closed this Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failure with newer pytz versions
4 participants